FaserF / hassio-addons

My personal Homeassistant Add-Ons. For more details have a look at the sub-folders.
54 stars 18 forks source link

[Bug]: Freenom-DNS-Updater can't read my config file #128

Closed blackie333 closed 1 year ago

blackie333 commented 1 year ago

The problem

Hello, I want to use your Freenom-DNS-Updater HA Add-On for renewal of my 3 freenom registered domains. After HA add-on installation today I prepared my config file according to maxisoft/Freenom-dns-updater example and put to my HA server as /share/freenom.yaml image

Add-on configuration is simple: image

image

Can't find out where am I doing mistake, any advice is really appreciated.

What version of Home Assistant Core has the issue?

2023.2.5

What version of the addon has the issue?

Current version: 1.2.2

What type of installation are you running?

Home Assistant OS

Add-On causing the issue

Freenom-DNS-Updater

Log information

s6-rc: info: service s6rc-oneshot-runner: starting
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
s6-rc: info: service legacy-services successfully started
parse error: Expected string key before ':' at line 1, column 4
[09:30:36] ERROR: Unknown HTTP error occured
Seems there is no config file at null
Check the path again. Exiting script now
s6-rc: info: service legacy-services: stopping
s6-rc: info: service legacy-services successfully stopped
s6-rc: info: service legacy-cont-init: stopping
s6-rc: info: service legacy-cont-init successfully stopped
s6-rc: info: service fix-attrs: stopping
s6-rc: info: service fix-attrs successfully stopped
s6-rc: info: service s6rc-oneshot-runner: stopping
s6-rc: info: service s6rc-oneshot-runner successfully stopped

Additional information

My HomeAssistant is based on HAOS installation using HTTPS via "Nginx Proxy Manager" Add-On. Home Assistant 2023.2.5 Supervisor 2023.01.1 Operating System 9.5 Frontend 20230202.0 - latest

FaserF commented 1 year ago

Thanks for the feedback. Fixed with the newest version 1.2.3

blackie333 commented 1 year ago

Thanks a lot for ultra fast fixing and releasing the new version :)

It's seems to be working now, my domains renewal period (14 days) starts tomorrow so I will check again. There are some warnings in the log, not sure whether it's normal so I copy the log output just FYI:

/usr/lib/python3.10/site-packages/freenom_dns_updater/encrypted_string.py:28: UserWarning: Using default key is not secure at all warnings.warn("Using default key is not secure at all") Error while updating: can't parse the given html No record updated Starting FDU every 86400 with the config file /share/freenom.yaml /usr/lib/python3.10/site-packages/freenom_dns_updater/encrypted_string.py:28: UserWarning: Using default key is not secure at all warnings.warn("Using default key is not secure at all") /usr/lib/python3.10/site-packages/freenom_dns_updater/scripts/fdu.py:298: UserWarning: Traceback (most recent call last): File "/usr/lib/python3.10/site-packages/freenom_dns_updater/scripts/fdu.py", line 294, in record_action action(freenom, rec) File "/usr/lib/python3.10/site-packages/freenom_dns_updater/scripts/fdu.py", line 208, in ok_count, err_count = record_action(lambda freenom, rec: freenom.add_record(rec, True), config, ignore_errors) File "/usr/lib/python3.10/site-packages/freenom_dns_updater/freenom.py", line 67, in add_record records = self.list_records(record.domain) File "/usr/lib/python3.10/site-packages/freenom_dns_updater/freenom.py", line 60, in list_records ret = RecordParser.parse(r.text) File "/usr/lib/python3.10/site-packages/freenom_dns_updater/record_parser.py", line 14, in parse raise ValueError("can't parse the given html") ValueError: can't parse the given html warnings.warn(traceback.format_exc()) Updated 0 record No record updated /usr/lib/python3.10/site-packages/freenom_dns_updater/encrypted_string.py:28: UserWarning: Using default key is not secure at all warnings.warn("Using default key is not secure at all") Successfully Updated 3 domains

FaserF commented 1 year ago

Yes this is "normal" :) and comes from the program https://github.com/maxisoft/Freenom-dns-updater

blackie333 commented 1 year ago

Renewal period (14 days) for my domains just started today so I wanted to check whether it's working...

Unfortunately my domains have not been renewed yet, run it 4 times today but still no domain renewed. image I can click on "Renew This Domain" button manually where I must choose a period (1-12 months). image

There is no renewal period setting in the maxisoft config file. Not sure if this could be the problem reason. The log looks exactly the same like yesterday.

I have a static IP so I don't need to update DNS records, only to renew my 3 domains every 12 months... I want to assign this important task to some automation without memory issues like me :) Would be very grateful if you could look into this. Thanks

blackie333 commented 1 year ago

Sorry, seems freenom needs some time to update it's website content. Checked again today afternoon and all my domain are listed as renewed. image

FaserF commented 1 year ago

perfect, thanks for the Feedback :)