Fasguy / MinecraftToolbox

A WebApp that provides tools for mixing up your Minecraft gameplay
https://fasguy.net/minecraft_toolbox
MIT License
8 stars 3 forks source link

Random Assistant Curseforge link instead of GitHub #39

Closed Bawnorton closed 1 year ago

Bawnorton commented 1 year ago

Thanks for linking to my Random Assistant mod on your website, it would be appreciated if you could link it to the curseforge page instead of my GitHub page as Minecrafters tend to be more familiar with curseforge than GitHub and don't know where to go to download: https://www.curseforge.com/minecraft/mc-mods/random-assistant

I was going to make a pull req but it doesn't seem that your GitHub repo is up to date with the current version of your website.

Fasguy commented 1 year ago

Yeah, i initially included the GitHub link, because i wasn't sure if you'd be uploading the mod to CurseForge while it's still in the "early" development stage, but didn't think far enough ahead to just ask you or... just check.

Also, regarding I was going to make a pull req but it doesn't seem that your GitHub repo is up to date with the current version of your website. Could you tell me what made you think that? Both the /trunk and the /dev branch are on-par with the version i currently have up on my website, so there shouldn't be discrepancies.

Bawnorton commented 1 year ago

Thanks

Could you tell me what made you think that? Both the /trunk and the /dev branch are on-par with the version i currently have up on my website, so there shouldn't be discrepancies.

Not sure if I'm doing something wrong as I am not familiar with angular but I couldn't find the link or project name anywhere in the project

Screenshot 2023-03-30 at 11 20 01 PM

and grep came up empty.

Screenshot 2023-03-30 at 11 29 58 PM
Fasguy commented 1 year ago

Ah, yeah that makes sense. The additional resources are actually part of the metadata for the version that has been selected, so they're part of the data.zip file. I've updated the links really quick, you can check that in commit 7f12d31, if you want. I'll update the website in a bit.