Closed DSCaskey closed 7 months ago
What an exciting progress! π Let's go through the amazing changes this PR brings to the table:
π Added a new dialogue, "About 2D App". This is encapsulated in two new files about2d_dialog.cpp
and about2d_dialog.h
in src/app/seamly2d/dialogs
directory. This creative move enhances our application UX by providing impactful information about the 2D feature of our app. π
π Said goodbye to old code. Removed the "About App" dialog, reflected in the removal of dialogaboutapp.cpp
and dialogaboutapp.h
. But don't worry! π We replaced it with our shiny new "About 2D App" dialog.
π Revamped some lines in mainwindow.cpp
to ensure communication is on point! Can't read image
was changed to a more intuitive Import Image
and we switched DialogAboutApp
with About2DAppDialog
in two places. Small stuff but they're making the app better one step at a time. πΆββοΈπΆββοΈ
𧽠Gave mainwindow.ui
a little clean-up. We swept away trailing whitespace and extra space in the Text
property of Images tools
QMenu action. Cleanliness is next to effectiveness! π§Ήπ―
π οΈ Some under-the-hood changes. In image_dialog.cpp
, the nameChanged
function was replaced with ui->filename_Label
. A subtle change that makes things work even better!
π Tweaked the image_dialog.ui
. We changed the maximum width of the dialog and rearranged certain items in the layout, making the UI more pleasing π We also added a QLabel widget for the "filename" label.
π Lastly, in src/libs/vmisc/projectversion.cpp
, we added if
statements to check the value of _MSC_VER
and return the corresponding MSVC version string. Think of it as our way of making sure the app knows what's up. π§
Keep up the good work, team! Excited to see these changes in action! ππ
Overall looks great, thank you!
I checked on macOS and there the build date (using the artifact from the github action) did not show, only the time:
It happens both in the general and in the more detailed system dialog:
Other than that it looks good:
I'll check if the build date works on the current releases.
Yes, currently its still working fine on macOS (with latest release 2024.4.15):
@csett86
Overall great, just the build date is broken on any non-US locale, but that should be an easy fix by reverting to the previous line of code
I checked the code... seems that there's a difference between QLocale() and QLocale::c() with the date. I reverted the date back to QLocale::c() so it should be fine now.
@csett86
Did the change back to QLocale::c() fix the date issue? If so can we merge?
Yes, its now looking good, I also just fixed the German translation as we are on it anyway (It was wrong before already, no regression, just while testing it I noticed it):
I'll now merge
This enhances the layout of the About dialog and updates the contributors.
Dialog is now split into 3 tabs.
About - Displays the basic build and legal information. This tab also adds a Copy to Clipboard that copies the build and system information to the clipboard that can then be pasted into for ex: a bug report.
Moves the downloading widget to the button box area .
Now displays the proper compiler version for MSVC when MSVC 2019 or greater.
System - Displays extended information about the build and machine system.
Contributors - Displays the list of project contributors. Fixes the list so it is actually in alphabetical order. Updates the list with new contributors.
Fixes the Image Dialog so it is parented to the Mainwindow.
This closes issue #1094