FashionFreedom / Seamly2D

Open source patternmaking software to democratize fashion.
https://seamly.io
GNU General Public License v3.0
617 stars 111 forks source link

feature: Enhance and update about dialog #1095

Closed DSCaskey closed 7 months ago

DSCaskey commented 7 months ago

This enhances the layout of the About dialog and updates the contributors.

Dialog is now split into 3 tabs.

This closes issue #1094

what-the-diff[bot] commented 7 months ago

πŸš€ PR Summary

What an exciting progress! πŸŽ‰ Let's go through the amazing changes this PR brings to the table:

Keep up the good work, team! Excited to see these changes in action! πŸš€πŸŒˆ

csett86 commented 7 months ago

Overall looks great, thank you!

I checked on macOS and there the build date (using the artifact from the github action) did not show, only the time:

Bildschirmfoto 2024-04-20 um 18 48 09

It happens both in the general and in the more detailed system dialog:

Bildschirmfoto 2024-04-20 um 18 48 13

Other than that it looks good:

Bildschirmfoto 2024-04-20 um 18 48 15

I'll check if the build date works on the current releases.

csett86 commented 7 months ago

Yes, currently its still working fine on macOS (with latest release 2024.4.15):

Bildschirmfoto 2024-04-20 um 18 56 58
DSCaskey commented 7 months ago

@csett86

Overall great, just the build date is broken on any non-US locale, but that should be an easy fix by reverting to the previous line of code

I checked the code... seems that there's a difference between QLocale() and QLocale::c() with the date. I reverted the date back to QLocale::c() so it should be fine now.

DSCaskey commented 7 months ago

@csett86

Did the change back to QLocale::c() fix the date issue? If so can we merge?

csett86 commented 7 months ago

Yes, its now looking good, I also just fixed the German translation as we are on it anyway (It was wrong before already, no regression, just while testing it I noticed it):

Bildschirmfoto 2024-04-20 um 21 09 25

I'll now merge