icon: Add a bounding box around the icon to match Apple and GNOME guidelines

FashionFreedom / Seamly2D

Open source patternmaking software to democratize fashion.

https://seamly.io

GNU General Public License v3.0

617 stars 111 forks source link

icon: Add a bounding box around the icon to match Apple and GNOME guidelines #1163

Closed csett86 closed 3 months ago

csett86 commented 3 months ago

Apple has a 6.5% bounding box, taken from https://developer.apple.com/design/resources/

GNOME has a 3% box for round icons (4px/128px), see https://gitlab.gnome.org/Teams/Design/HIG-app-icons/blob/master/template.svg

KDE also has a 3% box (4px/128px), see https://develop.kde.org/hig/icons/colorful/

csett86 commented 3 months ago

Still WIP, I need to update the copies in src/libs/vmisc/share/resources/icon as well

DSCaskey commented 3 months ago

Why are we resisizing these icons? Those are application icons not file icons. Your're changing the size of the icon that is used for ex in windows and dialogs:

If you want the file icons they're located in Seamly2d/dist

csett86 commented 3 months ago

Thanks @DSCaskey, I also noticed that I got the wrong icons. Sorry for the noise... What I want to achieve: Currently Seamly2D looks "too big" in the macOS task bar, as its filling all the space, while all the other icons are smaller and have a rectangular shape, even natually round ones like the Photos app or Firefox:

I will redo this and use the places where the mac application icons (Seamly2D and SeamlyMe) are stored, and just start there. Then tackle linux later...

csett86 commented 3 months ago

Continued in #1167