FashionFreedom / Seamly2D

Open source patternmaking software to democratize fashion.
https://seamly.io
GNU General Public License v3.0
618 stars 111 forks source link

Feature: Link measurement files with templates #131

Open sconklin opened 7 years ago

sconklin commented 7 years ago

From @sconklin on August 2, 2017 15:54

Originally reported by: bespoketailor (Bitbucket: bespoketailoring, GitHub: Unknown)


So right now you can create a template, but it's function is pretty useless. See this usecase:

User creates a pattern. It is a well-developed pattern and he wants to start working with it for customers. So he measures and measures and measures. He creates new measurements for customers from his template.

Now he adds some features to his pattern, decides to use more measurements, now he adjusts his template. All new measurement files are based on this new template. However, all old measurement files are still based on the old one. If he uses a new measurement inside his pattern, all old measurement files can no longer be used, since it will give an error of "can't load measurement file, please provide #measurementX"

Now I can remember using dreamweaver from Adobe way back when I used to make websites. You'd make a template, then create new pages from that template (it was linked). When you adjusted the template, you'd automatically get the question saying; "Pages x y and z use template A. Would you like to update these pages?"

I think this would be a good addition to valentina.


Copied from original issue: valentina-project/vpo2#741

sconklin commented 7 years ago

Original comment by Roman Telezhynskyi (Bitbucket: dismine, GitHub: dismine):


Good that we understand each other.

sconklin commented 7 years ago

Original comment by Susan Spencer (Bitbucket: suzynumena, GitHub: Unknown):


Yes, we are both supposed to approve.

sconklin commented 7 years ago

Original comment by Roman Telezhynskyi (Bitbucket: dismine, GitHub: dismine):


Good. But without my approval this is just a proposal. So, don't wait too long. Because i already ready implement @bespoketailoring's proposal. This will happen very soon. With or without your results.

sconklin commented 7 years ago

Original comment by Susan Spencer (Bitbucket: suzynumena, GitHub: Unknown):


There was a templates and multisize tables redesign meeting last week, conducted by two super users (grace & kmf). I have the results, just need to post them in the relevant issues.

sconklin commented 7 years ago

Original comment by Roman Telezhynskyi (Bitbucket: dismine, GitHub: dismine):


About which template redesign you are talking?

sconklin commented 7 years ago

Original comment by Susan Spencer (Bitbucket: suzynumena, GitHub: Unknown):


The templates redesign will supercede this request, this approach won't be necessary.

sconklin commented 7 years ago

Original comment by bespoketailor (Bitbucket: bespoketailoring, GitHub: Unknown):


Either way it would be a vast improvement for handling large amounts of measurement files :)

sconklin commented 7 years ago

Original comment by Roman Telezhynskyi (Bitbucket: dismine, GitHub: dismine):


I thought about scenario 1. But update will do only Tape.

sconklin commented 7 years ago

Original comment by bespoketailor (Bitbucket: bespoketailoring, GitHub: Unknown):


And yes, of course these new measurements will default to 0. (unless a template default value has been assigned)

sconklin commented 7 years ago

Original comment by bespoketailor (Bitbucket: bespoketailoring, GitHub: Unknown):


I don't know what's easier to implement. There could be 2 scenarios of which one would be harder to execute in my mind.

Scenario 1:

Measurement file A and B have been based on Template X.

User updates Template X. Next time Measurement file A is opened, it detects that it's template has been changed, and prompts to update. Measurement file B is opened again, again a prompt asking if user wants to update.

Scenario 2:

Template X is part of a "project" (much like dreamweaver). Within this project, there is a list of measurements, to be used with the pattern files within the same project. This project houses a list of measurement files and on which template they are based.

Template X is updated. Valentina prompts user and asks whether or not user wants to update all measurement files based on that template.

sconklin commented 7 years ago

Original comment by Roman Telezhynskyi (Bitbucket: dismine, GitHub: dismine):


Is this correct? Do you want to know which files use a template and add new measurements there? Only records without values? But you still will need to open each updates file and edit new measurements if not they will left 0.

sconklin commented 7 years ago

Original comment by Roman Telezhynskyi (Bitbucket: dismine, GitHub: dismine):


Let me think.

sconklin commented 7 years ago

Original comment by bespoketailor (Bitbucket: bespoketailoring, GitHub: Unknown):


I think issue 733 and this one can be merged.

sconklin commented 7 years ago

Original comment by Roman Telezhynskyi (Bitbucket: dismine, GitHub: dismine):


Did you hear about issue #733?

KimMF commented 6 years ago

This issue could be helped greatly by incorporating code that already exists in the seamly.cloud application. The premise is that if a pattern is loaded with a measurement file that does not include all needed measurements, the user is offered the opportunity to add the measurements rather than having the program fail and crash

KimMF commented 6 years ago

see also issue #128

slspencer commented 4 years ago

SeamlyMe should allow creation of measurement files using a measurement template. The template can be selected when creating a new measurement file. The template can be stored here under Information Tab,and can update according to changes to the template: image

slspencer commented 4 years ago

Link measurement files to their templates. Update the measurement file when the template is updated, but only when new fields are added. If fields are deleted, ignore.