Closed m000z0rz closed 3 months ago
oh also you should add a oot
subfolder for the content of the scripts
folder I think
Thanks for the review @Yanis42 ! I added testing instructions to the PR description and pushed updates that I think should resove the issues you found.
The Majora's Mask decomp uses limb enums on their assets, which changes the generated .c files for objects enough that skeletons won't import. This patch series adds a script to check how many files import skeletons from a decomp folder (currently only 3/176 or 1.7% successful) and adds handling for parsing these limb enums and using their when adding limbs. After these changes, 166/174 (95.4%) import skeletons without throwing exceptions.
I did most of my manual testing by:
make setup
complete) so assets are extractedOOT Skeleton Exporter
section, import a skeleton from the MM decomp.Alternatively, you can use the test script introduced in the first commit.
cd
toscripts/oot
and runpython3 make_all_skeletons.py <path to your mm decomp> <output dir> ["1" to import animations too]
For example, with the MM decomp checked out to ~/git/mm and with
make setup
complete there, I runpython3 make_all_skeletons.py ~/git/mm test-out 1
And when it completes, I can open the blend file generated at
scripts/oot/test-out/assets/objects/object_dnj/object_dnj.blend
to see the Deku Butler successfully imported with all its animations.