search

Fast-64 / fast64

Blender based editor for scenes, meshes, and more in first-party N64 games
GNU General Public License v3.0
316 stars 74 forks source link

Create black-suggest.yml #455

Open coco875 opened 2 months ago

coco875 commented 2 months ago

will suggest what black found wrong automatically.

coco875 commented 2 months ago

I will make an example of PR later, but also don't know if it's useful because black are pretty easy to install and are easy to format with it

Lilaa3 commented 2 months ago

Not an expert on github actions but shouldn't you be using our specific version of black? the check is failing

coco875 commented 2 months ago

The fail is because of I don't setup the install correctly and will try to do how your action do

coco875 commented 2 months ago

Ok can't because he use the source directly but I will hard code the version That you use

coco875 commented 2 months ago

example https://github.com/coco875/fast64/pull/1

Lilaa3 commented 2 months ago

@Dragorn421 I think this could be neat, didn't you have to black format for reonu just a while ago?

coco875 commented 2 months ago

(I can also make an action who will PR black format when he detect it)

Dragorn421 commented 2 months ago

This is neat Is there a way to combine the two github actions in one? Both the lint check and suggestions are doing the same thing (black formatting)

coco875 commented 2 months ago

in one file or in one job ?

coco875 commented 2 months ago

and black format suggestion need to be trigger only for pull request not for push so it will be even hard to combine in one file

Lilaa3 commented 3 weeks ago

I don´t know how this could be merged into a single action, don´t see anything on the docs. Is it possible to check if there was a difference and use that to block merging? @coco875 It would also need to check if black . didn't fail for this! (I'll try to help but I can't promise much since I'm still learning these)

Lilaa3 commented 3 weeks ago

I tried to help coco implement a single job for both formatting suggestion and linting, see if you like it!