search

FastCGI-Archives / fcgi2

FastCGI.com fcgi2 Development Kit fork from http://repo.or.cz/fcgi2.git + last snapshot
Other
219 stars 73 forks source link

Question: How to do better infrastructure of fcgi things? #65

Open michal-josef-spacek opened 1 year ago

michal-josef-spacek commented 1 year ago

Hi all, I am a Perl programmer and Fedora/RHEL Perl packager. I am interested in the FCGI topic.

The actual situation is not fine for me. Upstream repo: https://github.com/FastCGI-Archives/fcgi2/ Perl repo: https://github.com/perl-catalyst/FCGI Both contains all, c library and Perl (and other). Sic! There is FCGI Perl module on CPAN. In Fedora is fcgi package, which contains 2.4.0 version with many patches. (https://src.fedoraproject.org/rpms/fcgi) In Fedora is perl-FCGI, which has bundled fcgi lib and isn't actual I think. Another patch.(https://src.fedoraproject.org/rpms/perl-FCGI). There are many warnings, I think issues in C code, Perl code. No tests in Perl code. I created some PRs to improve Perl module tests, still not merged.

I am proposing to change this nonsense situation. I could help to clean up, but I am looking for some consensus. My idea is to improve libraries step-by-step. Steps which I am proposing: 1) Upstream C version in https://github.com/FastCGI-Archives/fcgi2/ without Perl code 2) Perl version is in https://github.com/perl-catalyst/FCGI without C lib 3) CPAN version is updated across https://github.com/perl-catalyst/FCGI 4) I could improve the Perl side of functionality. 5) I will help with the Fedora fcgi package to be updated to https://github.com/FastCGI-Archives/fcgi2/ Including monitoring of releases. 6) I will help with the Fedora perl-FCGI package to be updated to the CPAN version. Including monitoring of releases. 7) I will create Alien::FCGI module to deliver/detect fcgi c library to a system for Perl binding. (independent Perl repo) 8) I probably could help with c library too, there are some issues in quality.

The result will be a situation when each repository contains concrete things and we could improve them.

What do you think?

michal-josef-spacek commented 1 year ago

CC: @karenetheridge

karenetheridge commented 2 weeks ago

I found a notification for this issue buried in a pile of notifications that were archived without being read (sorry! github is very spammy).

This sounds good to me. I have created a github organization https://github.com/orgs/perl-catalyst/teams/fcgi-contributors and invited you to it, and given that org "maintainership" permissions on the FCGI repo, which is read/write and also allows for configuring github actions etc.

I don't have the permissions on PAUSE to give you release authority, as first-come permissions are held by someone else, but I've contacted them about that.

mcarbonneaux commented 1 week ago

in fact i've collected the old fastcgi.com archive from wayback machine and i've stored in this github org. and original fcgi2 project contain c code and perl code (in perl directory). and when i've done this i've not seen that cpan have all the same code (it's copy of the same code that are her...that contain c and perl code, but with many change on perl part)...

you can keep only perl thing on https://github.com/perl-catalyst/FCGI i think is good.

but in my opinion this repos must store the original code (with update patch), the idea is to have an archive of the original code (i can add comment in perl part that redirect to https://github.com/perl-catalyst/FCGI for the perl part) and for this reason i prefer to not remove the perl part.

plus some other distribution now use this repository (ubuntu for example)... and i'm not sure that all use only the libfcgi part...

liste of the patch listed in your repository list :

i think all are included in this repository.

it's possible to contribute to the perl part change (of this repo) to be in sync with the https://github.com/perl-catalyst/FCGI.

i accept all contribution to this repository without problem.

for the rest i'm ok!

for exemple ubuntu use https://github.com/perl-catalyst/FCGI for the perl part and my repo for the c/cpp part.

mcarbonneaux commented 1 week ago

i've done merge from master of perl-catalyst/FCGI perl part into perl-FCGI-merge, and i've added github actions to test build (including perl part).