FastFelix771 / TownyWands

A highly customizable GUI plugin for Towny to make the life of Minecraft players a little bit easier.
http://dev.bukkit.org/bukkit-plugins/townywands/
GNU General Public License v3.0
4 stars 2 forks source link

Crash after use t deposit in resgui #5

Closed Ectabro closed 8 years ago

Ectabro commented 8 years ago

Hello,

Like i said in the title, i crash after use the t deposit. The sign appear, i wrote 50 for exemple, and when i press done, i'm sent to my lobby server. But in the console i can't see any error and the 50 was in my town.

Any idea ?

FastFelix771 commented 8 years ago

Ive heard of such problems before ... are u using VentureChat? Is there any error in bungeecords console?

Ectabro commented 8 years ago

I don't use venturechat, but i didn't check for bungee. In the config i put bungee to false

FastFelix771 commented 8 years ago

Hmm, what are your versions of bungee / minecraft and TownyWands - Updating bungee helped the last guy with this Situation

Ectabro commented 8 years ago

I'm using spigot 1.9.2, with the last version of bungee and TownyWands 2.0.9

FastFelix771 commented 8 years ago

I will test that out, today. Thanks

Ectabro commented 8 years ago

Thanks

FastFelix771 commented 8 years ago

Last version of bungee? So BungeeCord for 1.10? Then i guess you are using ViaVersion or ProtocolSupport to connect 1.9.2 and 1.10?

You can also try out TownyWands 2.0.8 - it should work with 1.9 spigot - v2.0.9 was only tested with 1.10.2 so far

Ectabro commented 8 years ago

Okay after some check, we're running the the 1142 bungeecord build, and it's a 1.9 build, so it's okay. I try the 2.0.8 and come back after

Ectabro commented 8 years ago

okay with the 2.0.8, and protocollib removed everithing work, maybe we just need to update bungeecord ?

FastFelix771 commented 8 years ago

It could help, but maybe 2.0.9 is just broken in 1.9 - i focused on 1.10 support on this build. But i will test and fix that.. its still meant to be compatible down to 1.6.4

Updating ProtocolLib could help a lot probably.

Ectabro commented 8 years ago

i have a test server with exactly the same plugin and version, juste bungee is missing, and everything work with townywands 2.0.9 and spigot 1.9.2, i think i'ts because of bungee

FastFelix771 commented 8 years ago

Then updating Bungee is absolutely worth a try!

Ectabro commented 8 years ago

I test it tommorow morning !

Thanks for your help and for your wonderful plugin !

FastFelix771 commented 8 years ago

So, was your test succesful?

Ectabro commented 8 years ago

With the last version of bungee, townywands 2.0.9 and protocollib 4.0.1, the sign appear but when i enter, nothing happen, i haven't error and when i click again on the gold block for t deposit, nothing happe, no sign appear...

FastFelix771 commented 8 years ago

Try with this one: http://ci.dmulloy2.net/job/ProtocolLib/301/ Its the very latest version of ProtocolLib (4.0.2) and should work with 1.9

I just tested it and it seems to work ._. If that wont fix your problem, there must be a problem with BungeeCord... again... maybe i need to make an bungee plugin to solve that

Ectabro commented 8 years ago

I'm sorry but i can't install the last protocollib, because i'm on 1.9.2 :/

FastFelix771 commented 8 years ago

I know, i tested it with 1.9.2 :) Its backwards compatible

Ectabro commented 8 years ago

Sorry for the long time without answer, i have just tested TownyWands 2.0.9, the last version of bungee, and protocollib 4.0.2. When i click on the gold block, the sign appear, i enter 50 for exemple, and when i press done, nothing happen. After that, when i click again on the gold block nothing happen, and i haven't error in the console

FastFelix771 commented 8 years ago

I guess i know the problem... the vsign probably doesnt show again because the last one is still waiting for an answer packet from your game... wich will never come. the question is: why?! it works without bungee, so there must be a problem between protocollib and bungeecord... i'll open an issue on ProtocolLibs Git repo, maybe comphenix or dmulloy2 haves an idea :(

FastFelix771 commented 8 years ago

But there is also another way.. maybe. Ive made some cleanup to the Packet Stuff since i dropped support for NMS and completely switched to ProtocolLib - and well.. maybe it fixes your problem. The classes are much smaller now and therefore much less things can go wrong in theory.

Ectabro commented 8 years ago

I hope to !

Ectabro commented 8 years ago

So have you find a solution ?

FastFelix771 commented 8 years ago

I think so. Also, the vSign part has been split into its own module, for later use as an standalone plugin. On 2.1.0, i need to finish the ingame editing thing first... i dont want to over complicate it with 1000 commands like PermissionsEx ._. On the other side, i need to bring in all the features, the config had... :D

Well, i could try to create a hotfix with the 2.0.9 codebase, until i tested the new vSign module. Hopefully that will work.

Ectabro commented 8 years ago

So cool ! :D

I'm excited to test it soon !

FastFelix771 commented 8 years ago

For some reason, the version detection is broken -.- It delays things more than i like... but i guess that will be fixed with the help of ProtocolLib. And i was able to finally add support for MC 1.5 :3 But that still needs to be tested.

Ectabro commented 8 years ago

I'm still waiting, no problem :p

FastFelix771 commented 8 years ago

https://services.unitygaming.de/jenkins/job/TownyWands/16/artifact/target/TownyWands-2.0.9-SNAPSHOT-shaded.jar Take this jar and try it out! :) It works on 1.10 and 1.9, and with the bungeecord version i tested it. If it doesnt solve your problem, thats really bad luck :c

The new vSign module seems to do a great job, i really hope it works for you!

Ectabro commented 8 years ago

I'm sorry but it's the same.. Nothing happen and no error in the console.

After that when i click on the gold block nothing happen

For info i'm using the last version of protocollib, 4.0.2 and for bungee the build #1167

FastFelix771 commented 8 years ago

Dammit! BungeeCord really starts making me angry... Is it possible for you to upgrade to 1.10 Spigot?

You could try switching the use-native-transport setting in your server.properties (if it still exists in 1.9)

Ectabro commented 8 years ago

I'll ugrade to 1.10 !

FastFelix771 commented 8 years ago

:3 That hopefully works better. I really suspect BungeeCords 1.10 to 1.9 "translation" mechanism to screw up my packets^^ Maybe its some kind of validation that filters them, i dont know :c

FastFelix771 commented 8 years ago

Any update? Did it work on 1.10? :)

FastFelix771 commented 8 years ago

Well, i assume everything works now on 1.10. If you run into a problem, feel free to open a new issue! :)