search

FastFilter / fastfilter_cpp

Fast Approximate Membership Filters (C++)
Apache License 2.0
261 stars 24 forks source link

Not all fd are closed in destructor #14

Open Jens-H opened 3 years ago

Jens-H commented 3 years ago

https://github.com/FastFilter/fastfilter_cpp/blob/5f4f425a982bf6d770ff4ce38edc473487d5921d/benchmarks/linux-perf-events.h#L56

I believe you are not closing all fd that are opened in the for loop of the constructor.

Best regards Jens

lemire commented 3 years ago

If you believe that there is an issue, please provide a pull request providing a fix.