search

FastFilter / fastfilter_cpp

Fast Approximate Membership Filters (C++)
Apache License 2.0
261 stars 24 forks source link

This PR cleans up several schemes that we would not want people to look at, use or benchmark. #21

Closed lemire closed 3 years ago

lemire commented 3 years ago

We have accumulated a lot of schemes that are unlikely to be useful. They add noise and confusion for people look at the code.

It can be stressful when studying a code base to have all this dead code. How are you going to tell what is relevant and what is leftover from unsuccessful experiments? I think it is best to remove old code.

Note that with git, this code is not really gone: we can easily access it at any time by going to older commits.

This PR removes 4000 lines of code!

lemire commented 3 years ago

@thomasmueller I think we should consider this PR. Would you look at it?

Note that deleted schemes are always available under git, the history is not lost.

lemire commented 3 years ago

I'm fine with all your comments and I agree we can (and should) drop the lowmem qualifier.

The goal here is to make it easier for people who look at this code base to figure out what is what. We currently have way too many classes that should be ignored by readers (but they can't tell apart what they should ignore from what they should not).

thomasmueller commented 3 years ago

There are currently some problem with github it seems...