search

FastFilter / fastfilter_java

Fast Approximate Membership Filters (Java)
Apache License 2.0
238 stars 27 forks source link

[proposal] implement builder API #13

Closed richardstartin closed 4 years ago

richardstartin commented 4 years ago

Will build cleanly if #14 is merged and the ensuing merge conflict is resolved.

thomasmueller commented 4 years ago

This will now need some work before it can be merged. But I think the changes are great!

richardstartin commented 4 years ago

Yes, but trying to resolve the merge conflict shows how handy the enum factories are, so this might require some more thought. On the one hand, the enum makes it easy to represent a factory as data, on the other it enforces uniform parameter lists and can't be type-safe. Perhaps there is a happy medium.