False negative in Golomb compressed set 2 (test directory)

FastFilter / fastfilter_java

Fast Approximate Membership Filters (Java)

Apache License 2.0

238 stars 27 forks source link

False negative in Golomb compressed set 2 (test directory) #19

Open richardstartin opened 4 years ago

richardstartin commented 4 years ago

Steps to reproduce:

Hash.setSeed(-2130647756636796307L);
long[] keys = new long[] {1, 2, 3};
int bitsPerKey = 8;
var filter = GCS2.construct(keys, bitsPerKey);
assertTrue(filter.mayContain(1)); // false

thomasmueller commented 4 years ago

I temporarily disabled the test, will try to work on this next year.

thomasmueller commented 4 years ago

Moved the implementation to the test directory. I think the bug is in BitBufferDirect.