Closed steve-scalyr closed 2 years ago
@thomasmueller could you take a look? This PR contains the infinite loop guard proposed in the discussion of https://github.com/FastFilter/fastfilter_java/pull/30. I also took the opportunity to read through the code to make sure I understood all of it, and along the way I made a few other small changes.
Thanks!
One last request: would it be possible to publish a new release (1.0.3) now?
This PR contains some minor changes to the
XorPlus8
class:this.
when assigning instance fields in constructorbitCount
; remove an unused constructor that was assigning it incorrectlyRegarding the unused constructor that I removed: it did not populate
seed
orrank
, and I believe the latter means that any attempt to use the instance created by this constructor would have resulted inNullPointerException
.The changes are small, but can most easily be reviewed one commit at a time.