Closed yangzq50 closed 8 months ago
Should include binaryfusefilter.h instead in the C++ wrapper example. https://github.com/FastFilter/xor_singleheader/blob/1f7e18b2c1de0854e0da75d49a471d37c03e9e5f/README.md?plain=1#L77
binaryfusefilter.h
The first parameter of AddAll() cannot be const, because it may be edited by function binary_fuse_sort_and_remove_dup(). https://github.com/FastFilter/xor_singleheader/blob/1f7e18b2c1de0854e0da75d49a471d37c03e9e5f/README.md?plain=1#L90-L92
Member variable name already changed from fingerprints to Fingerprints in commit b8268c9dbf3bb73e4fa50315f6287d20c85e8e78 . https://github.com/FastFilter/xor_singleheader/blob/1f7e18b2c1de0854e0da75d49a471d37c03e9e5f/README.md?plain=1#L100
Should include
binaryfusefilter.hinstead in the C++ wrapper example. https://github.com/FastFilter/xor_singleheader/blob/1f7e18b2c1de0854e0da75d49a471d37c03e9e5f/README.md?plain=1#L77The first parameter of AddAll() cannot be const, because it may be edited by function binary_fuse_sort_and_remove_dup(). https://github.com/FastFilter/xor_singleheader/blob/1f7e18b2c1de0854e0da75d49a471d37c03e9e5f/README.md?plain=1#L90-L92
Member variable name already changed from fingerprints to Fingerprints in commit b8268c9dbf3bb73e4fa50315f6287d20c85e8e78 . https://github.com/FastFilter/xor_singleheader/blob/1f7e18b2c1de0854e0da75d49a471d37c03e9e5f/README.md?plain=1#L100