search

FastFinTech / FFT.Oanda

FFT.Oanda is a .Net client for the Oanda api.
https://fastfintech.github.io/FFT.Oanda/
MIT License
10 stars 8 forks source link

AccountFinancingMode DAILY_INSTRUMENT value missing #18

Closed squideyes closed 8 months ago

squideyes commented 1 year ago

Hi!

I'm getting an error while parsing the AccountFinancingMode enumeration for a DailyFinancingTransaction because the DAILY_INSTRUMENT value is missing. I'm not quite sure what the value means, but as soon as I get the info back from OANDA I'll be sure make a pull request with the updated code.

truegoodwill commented 8 months ago

Thank you. Awesome pull request. I'm not sure if removing the cancellation tokens from the async enumerators was a good idea, I'll have to take a careful look at that. Thanks again.

traburi commented 7 months ago

Hi …

it was not my intention to remove the cancelation token, but in net8 the MoveNextAsync doesn’t take a token any longer.

Maybe the stream is still listening on the cancelation token from the initialisation, but I didnt check that

Uli

Von: True Goodwill @.> Gesendet: Tuesday, 19 March 2024 16:19 An: FastFinTech/FFT.Oanda @.> Cc: Subscribed @.***> Betreff: Re: [FastFinTech/FFT.Oanda] AccountFinancingMode DAILY_INSTRUMENT value missing (Issue #18)

Thank you. Awesome pull request. I'm not sure if removing the cancellation tokens from the async enumerators was a good idea, I'll have to take a careful look at that. Thanks again.

— Reply to this email directly, view it on GitHub https://github.com/FastFinTech/FFT.Oanda/issues/18#issuecomment-2007471026 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AWW6HGEMGBSEMGE3GH6CYRLYZBJN7AVCNFSM6AAAAAA2V6PYKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBXGQ3TCMBSGY . You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/AWW6HGAS7YEUHLNH6JCHLK3YZBJN7A5CNFSM6AAAAAA2V6PYKKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTXU6J3E.gif Message ID: @. @.> >