search

FastNFT / FNFT

Fast numerical computation of (inverse) nonlinear Fourier transforms
https://fastnft.github.io/FNFT/
GNU General Public License v2.0
42 stars 12 forks source link

Bug fix nsep #53

Closed wahls closed 4 years ago

ShrinivasJC commented 4 years ago

Can you please check the changelog once?

wahls commented 4 years ago

Can you please check the changelog once?

I made it a bit more explicit. Regarding commit 33b1b54: D=2 is allowed as well, is it not?

By the way, should we put a comment somewhere in fnft_nsep.c which explains why D=power of two is currently required?

This might become handy at some point in the future...

ShrinivasJC commented 4 years ago

Can you please check the changelog once?

I made it a bit more explicit. Regarding commit 33b1b54: D=2 is allowed as well, is it not?

You are right. I will correct the documentation to say D>=2

By the way, should we put a comment somewhere in fnft_nsep.c which explains why D=power of two is currently required?

This might become handy at some point in the future...

I will add a few comments.

wahls commented 4 years ago

Many thanks!