FasterXML / jackson-core

Core part of Jackson that defines Streaming API as well as basic shared abstractions
Apache License 2.0
2.27k stars 795 forks source link

No tests for verifying basic functioning of `RecyclerPool` implementations (#1064) #1190

Closed cowtowncoder closed 9 months ago

cowtowncoder commented 9 months ago

(note: spun off of https://github.com/FasterXML/jackson-databind/issues/4321)

One major new feature in Jackson 2.16 was addition of pluggable RecyclerPools (see #1064 f.ex). But unfortunately their functioning was not tested beyond regression testing for the default, ThreadLocal-based legacy RecyclerPool. Let's start by adding streaming-level testing first.

EDIT: there is actually one test -- BufferRecyclerPoolTest -- that verifies some aspects but is limited (only simple generation case, not parser), but we can do better.