search

FasterXML / jackson-core

Core part of Jackson that defines Streaming API as well as basic shared abstractions
Apache License 2.0
2.27k stars 795 forks source link

JDK compatibility issues with jackson-core 2.14 and later due to Multi-Release (MR) jars #1210

Open techwhizbang opened 9 months ago

techwhizbang commented 9 months ago

The time that the jackson-core library switched from using its own copy of the fasterdoubleparser code to the actual library this can cause JDK incompatibilities. The problem manifests itself if you take any newer version of the jackson-core libraries 2.14 or better and you need to do any type of dependency shading. If you do - the fasterdoubleparser uses a technique of putting all the class files across different JDK's well beyond the advertised JDK8 compatibility (https://github.com/FasterXML/jackson-core?tab=readme-ov-file#jdk) via the Maven assembly plugin (https://github.com/wrandelshofer/FastDoubleParser/blob/main/fastdoubleparser/src/assembly/mrjar.xml).

When shading you end up getting all the class files for all thefasterdoubleparser supported JDK's and if you aren't using the highest JDK version possible you will run into problems like this:

java.lang.IllegalArgumentException: Unsupported class file major version 63 at shadow.org.objectweb.asm.ClassReader.(ClassReader.java:199) at shadow.org.objectweb.asm.ClassReader.(ClassReader.java:180) at shadow.org.objectweb.asm.ClassReader.(ClassReader.java:166) at shadow.org.objectweb.asm.ClassReader.(ClassReader.java:287)

For example I am using JDK17 and the Gradle Shadow plugin. The ASM library aborts when it finds a class file that isn't inline with the JDK you are running.

This is easily reproducible if you use the Gradle Shadow plugin or the Maven Shade plugin and use JDK17 and include the jackson-core 2.15.2 as a dependency for example.

pjfanning commented 9 months ago

Please read https://openjdk.org/jeps/238 -- MR Jars are an important feature of Java.

Please raise this with Gradle and Gradle Shadow plugin. Try upgrading to latest Gradle and Gradle plugin.

I use Gradle and it works fine with jackson-core.

techwhizbang commented 9 months ago

I'm using Gradle 7.x and Gradle 8.x. It works fine with Gradle and in the context of a standard build.

The problem arises if you attempt to use the newer jackson-core library with the dependency on fasterdoubleparser in a shadow jar with either the Maven shade or Gradle shadow plugin.

I suppose your point is that the shadow plugins and libraries may need to be updated to work in harmony with https://openjdk.org/jeps/238.

GedMarc commented 9 months ago

Not quite, The classes are compiled in JDK 19 and you are building with JDK 17. Version 63 = JDK 19

Also look at updating the ASM library dependency to support JDK 19, or 21 preferred, 9.6 I think it is

cowtowncoder commented 7 months ago

I think it is unfortunate there are issues wrt shading, MR jars. But I am not quite sure what could be done here to help?

Leaving issue open so anyone with problems can find it, and maybe we get some ideas for versions of tools that help, and perhaps workarounds.