Reuse own constant and refactor magic chars into new constants for public reuse

FasterXML / jackson-core

Core part of Jackson that defines Streaming API as well as basic shared abstractions

Apache License 2.0

2.27k stars 795 forks source link

Reuse own constant and refactor magic chars into new constants for public reuse #1216

Closed garydgregory closed 8 months ago

garydgregory commented 8 months ago

Hi @cowtowncoder

Also: Add missing Javadoc return tag

cowtowncoder commented 8 months ago

Thank you @garydgregory! Looks good, would be happy to merge.

Just one process thing: if we don't yet have a CLA (apologies if I missed earlier one, if so LMK), we'd need it from:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and as usual, easiest to print, fill & sign, scan/photo, email to cla at fasterxml dot com. Only needs to be done once before the first contribution.

Looking forward to merging this!

garydgregory commented 8 months ago

Hi @cowtowncoder CLA emailed.