search

FasterXML / jackson-databind

General data-binding package for Jackson (2.x): works on streaming API (core) implementation(s)
Apache License 2.0
3.53k stars 1.38k forks source link

Add any-setter handling in `PropertyValueBuffer` post #562 #4720

Closed JooHyukKim closed 1 month ago

JooHyukKim commented 1 month ago

fixes #4508

This sort of adds missing handling in addition to #562 fix. Where we should also consider situations like #4508, where extensions (like Kotlin module) iterates through parameters one by one, via hasParmeter() and getParameter(), unlike StdValueInstantiator going through all parameters at once via getParameters(SettableBeanProperty[]).

Reproduction with fix

  1. pull : https://github.com/JooHyukKim/jackson-module-kotlin/tree/test-databind-4508
  2. then pull : https://github.com/JooHyukKim/jackson-databind/tree/DEMO-fix-4508 (or directly pull the branch in this PR, just make sure to update the pom.xml in kotlin module accordingly.
  3. build the databind module
  4. run Github562Test
pjfanning commented 1 month ago

any way to test this in a unit test?

JooHyukKim commented 1 month ago

any way to test this in a unit test?

Will try to come up one soon!

JooHyukKim commented 1 month ago

Added reproduction (with fix) in PR descrption. cc @pjfanning @cowtowncoder

reneleonhardt commented 1 month ago

fixes #4508

This sort of adds missing handling in addition to #4508. Where we should also consider situations like #4508

You mentioned the same issue three times in a row, are all those references correct?

JooHyukKim commented 1 month ago

Right, one in the middle should be pointing to #562. Thank you @reneleonhardt !