search

FasterXML / jackson-databind

General data-binding package for Jackson (2.x): works on streaming API (core) implementation(s)
Apache License 2.0
3.53k stars 1.38k forks source link

test issue 4741 #4743

Closed pjfanning closed 1 month ago

pjfanning commented 1 month ago

see #4741

This test passes in 2.17 but fails in 2.18. Note that the 2.18 branch needs @Test annotations (Junit 4) while 2.17 uses Junit 3 style.

cowtowncoder commented 1 month ago

Ok makes sense.

Quick note: JUnit4 vs JUNit 5 (not 3 and 4).

pjfanning commented 1 month ago

@cowtowncoder tests where the methods needed 'test' as the prefix of the method name - that is junit 3. Junit 4 brought in @Test annotations. Junit 5 was the switchover to Jupiter but still has @Test annotations.

The code in this PR uses 'test' as the prefix of the method name to keep with the existing style in that class (in 2.17). The class changed in 2.18 and is now, I guess, junit 5 / jupiter style.

cowtowncoder commented 1 month ago

@pjfanning Ok, yes, conceptually JUnit 3 tests. Actual JUnit version being used is/was JUnit 4 until 2.18 conversion to JUnit 5.