Wrong `String.format()` in `StdDelegatingDeserializer` hides actual error

[Horus1337]

Search before asking

• [X] I searched in the issues and found nothing similar.

Describe the bug

In com.fasterxml.jackson.databind.deser.std.StdDelegatingDeserializer

is the method

protected Object _handleIncompatibleUpdateValue(JsonParser p, DeserializationContext ctxt, Object intoValue)
        throws IOException
    {
        throw new UnsupportedOperationException(String.format
                ("Cannot update object of type %s (using deserializer for type %s)"
                        +intoValue.getClass().getName(), _delegateType));
    }

The String format in there is wrong, there is a '+' instead of ',' so another Runtime Exception is thrown.

protected Object _handleIncompatibleUpdateValue(JsonParser p, DeserializationContext ctxt, Object intoValue)
        throws IOException
    {
        throw new UnsupportedOperationException(String.format
                ("Cannot update object of type %s (using deserializer for type %s)",
                        intoValue.getClass().getName(), _delegateType));
    }

fixes this

Version Information

since 2.6.0

Reproduction

String.format ("Cannot update object of type %s (using deserializer for type %s)" +"EXAMPLE", "STRING")

Expected behavior

String.format ("Cannot update object of type %s (using deserializer for type %s)", "EXAMPLE", "STRING")

Additional context

No response

[JooHyukKim]

Please try at least 2.18 version and rewrite the issue, @Horus1337 2.6 version is ancient and no longer maintained. Thanks!

[pjfanning]

I committed 8f139afb437d3f5bab8bc35bae680cc9af59831e. I accidentally committed directly, had intended to create a branch and a PR. @cowtowncoder feel free to revert this commit.

[cowtowncoder]

@pjfanning That's fine in this case. I think I'll even backport it to 2.16/2.17/2.18.

[Horus1337]

Thank you for the quick fix. I am using the most recent version, with the ' Version Information since 2.6.0 ' I just meant it was introduced in that version