Feature : Allow setting custom linefeed on DefaultXmlPrettyPrinter

[JooHyukKim]

• for #560

BEFORE

• Linefeed is set when static { } block from Lf2SpacesIndenter is run.
• both DefaultXmlPrettyPrinterand Indenters both use static Lf2SpacesIndenter.SYSTEM_LINE_SEPARATOR

AFTER

• _lineFeed is set when static { } block from DefaultXmlPrettyPrinter is run.
• Indenters ONLY customize indentations and linefeed value is given by DefaultXmlPrettyPrinter

[pjfanning]

I have to ask why you are not ensuring the code compiles?

The @Override should not have been added to the new lineFeed() method. In fact, it should not even be necessary. It is likely that Lf2SpacesIndenter can access the defaultXmlPrettyPrinter._lineFeed.

[JooHyukKim]

I have to ask why you are not ensuring the code compiles?

• My mistake, won't happen again 👍🏻👍🏻

The @Override should not have been added to the new lineFeed() method. In fact, it should not even be necessary. It is likely that Lf2SpacesIndenter can access the defaultXmlPrettyPrinter._lineFeed.

• I making Lf2SpacesIndenter non-static at the moment. Sorry for the confusion

[JooHyukKim]

Sorry it took me long to react! 🙏🏼 I just moved house 🥲🥲🥲 and it's taking so much time to pack and unpack stuff

I just got internet back, I will try to apply your feed back asap.

[JooHyukKim]

All reviews made up to this point are applied to the changes.

The only thing left is being discussed in the thread of comments above. Simply put, about how to(or whether) to apply custom new line while writing XML declaration with ToXmlGenerator.Feature.WRITE_XML_DECLARATION or not.

[cowtowncoder]

Thank you again @JooHyukKim ! Merged for inclusion in 2.15.0