search

FasterXML / jackson-dataformat-xml

Extension for Jackson JSON processor that adds support for serializing POJOs as XML (and deserializing from XML) as an alternative to JSON
Apache License 2.0
574 stars 222 forks source link

Fix #643: Add `ToXmlGenerator.Feature` or allowing XML Schema/JAXB compatible Infinity representation #644

Closed ahcodedthat closed 8 months ago

ahcodedthat commented 8 months ago

This PR adds a ToXmlGenerator.Feature to use XML Schema-compatible representation for floating-point infinity.

Fixes #643.

cowtowncoder commented 8 months ago

@ahcodedthat Excellent, looks good, I like the implementation.

One process thing before I can merge this: if we do not yet have CLA from you (one is enough for all contributions so this is needed just once), we'd need one from:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

(there's also corporate CLA as an alterative if preferred).

It is usually easiest to print, fill & sign, scan/photo, email to cla at fasterxml dot com.

Once I have it, can proceed with merge and this should nicely get into 2.17.0 as one of the (if not the :)) last feature to be included.

Looking forward to merging this nice addition; thank you again for submitting it!

cowtowncoder commented 8 months ago

Hoping to get CLA resolved by tomorrow as I will need to proceed with 2.17.0 release. Would not matter otherwise -- often things can go in patches -- but this is API change (addition) so needs to go in a minor release as per SemVer.

ahcodedthat commented 8 months ago

Sorry for the delay! I just sent the filled-out CLA.

cowtowncoder commented 8 months ago

Thank you @ahcodedthat for sending CLA -- I was counting on it getting done soon so it made it in 2.17! :)