search

FasterXML / jackson-dataformat-xml

Extension for Jackson JSON processor that adds support for serializing POJOs as XML (and deserializing from XML) as an alternative to JSON
Apache License 2.0
561 stars 221 forks source link

Added fix for iterable collection builder methods not treating iterable as a collection #648

Closed bpasson closed 3 months ago

bpasson commented 3 months ago

Added failing test and fix or issue #646

cowtowncoder commented 3 months ago

Looks good!

Before merging, one (and only) process thing: unless I've asked (and gotten) CLA, we'd need one from:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

before merging the PR. Only needs to be done once & is good for perpetuity. The usual way is to print, fill & sign, scan/photo, email to cla at fasterxml dot com. And once we have it, can go ahead and merge this fix.

Thank you once again for contributing this!

bpasson commented 3 months ago

@cowtowncoder you should have it shortly.

cowtowncoder commented 3 months ago

CLA received, pr merged!