search

FasterXML / jackson-dataformat-xml

Extension for Jackson JSON processor that adds support for serializing POJOs as XML (and deserializing from XML) as an alternative to JSON
Apache License 2.0
574 stars 222 forks source link

Add JDK 17 test functionality #672

Closed JooHyukKim closed 1 month ago

JooHyukKim commented 1 month ago

resolves #671

JooHyukKim commented 1 month ago

Tried manually failing jdk 17 to see if it works via https://github.com/FasterXML/jackson-dataformat-xml/pull/672/commits/e60e5f96b8de2009424f69f3c5d5103536ae0bb0. Works fine 👌🏼

cowtowncoder commented 1 month ago

Oh shoot. This was agaisnt 2.17 for some reason? I don't think we really needed that... although I guess that's ok.

JooHyukKim commented 1 month ago

@cowtowncoder My bad 🙉 I forgot to point out about the base branch.

extension modules tend to get updated less frequently so there will be more people reporting issues from earlier version, so I figured might as well get merged into reasonably earlier version.

cowtowncoder commented 1 month ago

My bad for not asking for re-base. Problem/challenge here was just merging, pom.xml does not merge cleanly so had to do more work.

We are very unlikely to backport fixes in 2.17 for any modules.

Still, it's all good, got it merged and we have it even for 2.17 :)