Inconsistent support for `StreamWriteFeature.FLUSH_PASSED_TO_STREAM`

FasterXML / jackson-dataformats-binary

Uber-project for standard Jackson binary format backends: avro, cbor, ion, protobuf, smile

Apache License 2.0

314 stars 136 forks source link

Inconsistent support for `StreamWriteFeature.FLUSH_PASSED_TO_STREAM` #155

Closed carterkozak closed 5 years ago

carterkozak commented 5 years ago

Cbor and Smile serializers attempt to flush streams on close when AUTO_CLOSE_TARGET is disabled, even if FLUSH_PASSED_TO_STREAM is also disabled.

cowtowncoder commented 5 years ago

Thank you for reporting this, showing the place where checks were missing. I had to do bit of massaging and ended up manually merging, to get this in 2.10 -- implementation has changed quite a bit between 2.x and (upcoming) 3.0.