search

FasterXML / jackson-dataformats-binary

Uber-project for standard Jackson binary format backends: avro, cbor, ion, protobuf, smile
Apache License 2.0
314 stars 136 forks source link

Add getIonSystem() accessor in IonFactory #204

Closed paulfferraro closed 4 years ago

paulfferraro commented 4 years ago

It is sometimes necessary to access the underlying IonSystem when interacting with an IonObjectMapper or ObjectWriter (eg. to replicate the logic in IonObjectMapper#writeValueAsIonValue()).

cowtowncoder commented 4 years ago

Makes sense, I can add this. Just one request: could you rebase against 2.11? In theory, being API add, should go in next minor version (2.12), but I think this is small enough thing it can go in 2.11.1. And since 2.10 is going in maintenance mode, I think 2.11 branch is the best place (I'll document it as addition in official 2.12, but versions 2.11.1 and up do contain it).

paulfferraro commented 4 years ago

Any chance I can convince you to push to 2.10 and merge to 2.11? Or back-port to 2.10? Many parts of the org just recently updated to jackson-databind-2.10 and I want to be able to bring the Ion support up to speed instead of using the old 2.8 version of jackson-over-ion support we currently have.

cowtowncoder commented 4 years ago

I guess that is ok (just wrt "unofficial" add -- will not be removed, just not documented), I don't see harm in there.