search

FasterXML / jackson-dataformats-binary

Uber-project for standard Jackson binary format backends: avro, cbor, ion, protobuf, smile
Apache License 2.0
314 stars 136 forks source link

Fix bug when deserializing Avro data using schema evolution #210

Closed marcospassos closed 4 years ago

marcospassos commented 4 years ago

This little typo caused us a serious problem when deploying to production a new version last week. We took several hours until we managed to track this bug down. It was hard to debug because it involves schema evolution.

When combining two schemas, if one of them has a map field, you got the following error:

Not an array: {“type”:“map”,“values”:..}

@cowtowncoder any chances of releases a patch version anytime soon? It'd help us a lot.

cowtowncoder commented 4 years ago

Would it be possible to add a unit test to verify and guard against the issue?

Also, this seems to be against master, but that is for 3.0.0-SNAPSHOT, so it probably needs to be against some other branch -- 2.10 assuming code hasn't changed (and I can merge forward); I am hoping to release 2.11.1 quite soon (2.10.5 probably will take time as there aren't that many fixes accumulated).

marcospassos commented 4 years ago

Sure, I will open a PR against 2.10 with unit tests. Any chances of releasing a patch version next week?

On Sun, Jun 21, 2020 at 22:13 Tatu Saloranta notifications@github.com wrote:

Would it be possible to add a unit test to verify and guard against the issue?

Also, this seems to be against master, but that is for 3.0.0-SNAPSHOT, so it probably needs to be against some other branch -- 2.10 assuming code hasn't changed (and I can merge forward); I am hoping to release 2.11.1 quite soon (2.10.5 probably will take time as there aren't that many fixes accumulated).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/FasterXML/jackson-dataformats-binary/pull/210#issuecomment-647212476, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHGHPE42NLIRHHHNHPVCB3RX2V4LANCNFSM4OEBDH3Q .

marcospassos commented 4 years ago

Surpassed by #211

cowtowncoder commented 4 years ago

Ok thanks, I will try to get this merged soon.

As to release, we'll see, I might get to releasing 2.11.1 over next weekend if all goes well. Maintaining everything with Jackson is so much work that it is getting hard to find time and inspiration to do this solely as community service, which is what it comes down to at this point. :-(