search

FasterXML / jackson-dataformats-binary

Uber-project for standard Jackson binary format backends: avro, cbor, ion, protobuf, smile
Apache License 2.0
314 stars 136 forks source link

Fix schema evolution involving maps of non-scalar #211

Closed marcospassos closed 4 years ago

marcospassos commented 4 years ago

Rework on branch 2.10, surpasses #210.

@cowtowncoder I've added tests to prevent regression as you asked.

Just reiterating, if possible, releasing a patch anytime soon would help us a lot :)

Please, let me know if you need anything else.

cowtowncoder commented 4 years ago

Merged. The reason I am not sure about 2.10 release is just low number of fixes as per

https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.10.5

(and since this is likely the last full patch set for 2.10)

whereas many more for 2.11:

https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.11.1

and so if possible it'd be great to verify that 2.10->2.11 could work for your use case. Every new full patch release takes 2-3 hours for me so I will need to balance time available on cutting releases.

cowtowncoder commented 4 years ago

Hmmmh. Looks like this change broke 2.12 tests :-(

cowtowncoder commented 4 years ago

.... or maybe it was already broken. Need to check into failure. Will add a note if I find something related to this change.

marcospassos commented 4 years ago

both 2.10 and 2.11 works for us, we just need a released version including the fix, so choose whatever requires less time of yours :)

About the broken tests, it's weird because the fix is a one-line change that is clearly a mistake (the test is the proof).

cowtowncoder commented 4 years ago

@marcospassos I think it is unrelated to this change, apologies for false alarm. It is related to coercion config changes in 2.12 somehow, need to figure out exactly how.

Thanks wrt 2.10/2.11; just wanted to know if you had specific constraints at this point.

cowtowncoder commented 4 years ago

Ah. Interesting. Databind wrongly prevent coercion from "Blank string" for Character, in case of a single white space characted. Something databind did not test but Avro module does.... Nice indirect catch. :)

marcospassos commented 4 years ago

Hey @cowtowncoder! Any idea on when it will be released?

cowtowncoder commented 4 years ago

@marcospassos I'll have to think of when to release 2.10.5: it might be the last 2.10 patch release and there haven't been that many fixes. So there's some balancing wrt how long to wait.

But I think this fix was included in 2.11.1 which has been released, if you can use that version?