search

FasterXML / jackson-dataformats-binary

Uber-project for standard Jackson binary format backends: avro, cbor, ion, protobuf, smile
Apache License 2.0
314 stars 136 forks source link

Add support to (de)serialize Ion timestamps with java.time classes #213

Closed mcliedtke closed 4 years ago

mcliedtke commented 4 years ago

(continued from: https://github.com/FasterXML/jackson-dataformats-binary/pull/208 - since I switched branches I opened a different PR)

Adding support for some java 8 java.time classes to (de)serialize to Ion's timestamp type.

Starting with just the following since it seemed pretty clear cut that there could be support:

I was less sure about how to handle java.time.LocalDate and java.time.LocalDateTime so they have been omitted.

Serialization is fairly straightforward, each class is pretty easily transformed into an Ion timestamp. The caveat is that the transformation for a java.time.ZonedDateTime will be slightly lossy since an Ion timestamp cannot represent the timezone, just the offset. In this case the local offset is used.

Deserialization is also mostly straight forward. In the event that the Ion timestamp's time local offset is unknown (-00:00), then the default timezone is used from the context.

(De)serialization to/from an Ion int or Ion decimal is added as well though I haven't tried to add support to/from an Ion string.

Some of the code could be refined with lambdas and function references in the future if this module is moved to java 8.

cowtowncoder commented 4 years ago

Merged for 2.12, will add info on release notes

cowtowncoder commented 4 years ago

Updated README, and also created dataformat-ion team (with @mcliedtke invited) to give push access (it'll be for whole repo, technically, although conceptually for Ion related changes).