search

FasterXML / jackson-dataformats-binary

Uber-project for standard Jackson binary format backends: avro, cbor, ion, protobuf, smile
Apache License 2.0
310 stars 133 forks source link

Avro null deserialization #216

Closed marcospassos closed 4 years ago

marcospassos commented 4 years ago

We found another issue related to schema evaluation, after deserialization of a null value. After a few hours of debugging, we found that the root issue has already been fixed, but it was not included in the latest release.

Is there any particular reason not to release this fix for 2.11.x versions?

cowtowncoder commented 4 years ago

Looking at #146 PR (for #145) originally submitted against master; I would not be against fix for 2.x if anyone has time to back port the change.

Since there is a new feature, it would have to go in 2.12(.0) however.

marcospassos commented 4 years ago

Is it ok if I provide a PR including only the fix for the null serialization issue?

marcospassos commented 4 years ago

PR opened.

cowtowncoder commented 4 years ago

Yes that makes sense.

marcospassos commented 4 years ago

Any ETA for 2.11.2?

cowtowncoder commented 4 years ago

I was hoping to hold off for bit longer as 2.11.1 was only released 1 month ago and total number of fixes is still quite low. But there are couple of important fixes so I think I will release this within a week, maybe over the weekend.

marcospassos commented 4 years ago

Thank you @cowtowncoder :)

cowtowncoder commented 4 years ago

2.11.2 was released on August 2nd, 2020.

marcospassos commented 4 years ago

Thank you @cowtowncoder.