Closed MichalFoksa closed 3 years ago
While I am +1 for improving naming, isn't this backwards-incompatible change, and something that can't really go in 2.13 but should wait for 3.0?
:( OK - rename is undone
Ok so I think I can see why this is needed. I added a note where naming seems confusing wrt method -- I think I can see why naming of the class is unfortunate.
Once we get past that, maybe it would make sense to also file a follow-up issue about actual renaming like you suggested first. I'd have to think if it actually could go in 2.14, after all, or at least in 3.0.
LGTM! Will merge.
Thanks!
To ease customization by a user I suggest to add protected method
AvroFormatVisitorWrapper
(exVisitorFormatWrapperImpl
) createVisitorWrapper() intoAvroFormatVisitorWrapperwhich
creates and returns a new instance of visitor wrapper. This method would be used on each place where new visitor instance is created in ArrayVisitor, MapVisitor and RecordVisitor.