Set StreamReadCapability.EXACT_FLOATS=true

FasterXML / jackson-dataformats-binary

Uber-project for standard Jackson binary format backends: avro, cbor, ion, protobuf, smile

Apache License 2.0

310 stars 133 forks source link

Set StreamReadCapability.EXACT_FLOATS=true #307

Closed htmldoug closed 2 years ago

htmldoug commented 2 years ago

This gets the ball rolling setting the StreamReadCapability.EXACT_FLOATS flag from https://github.com/FasterXML/jackson-core/pull/733 (issue: https://github.com/FasterXML/jackson-core/issues/730).

[x] Smile
[x] CBOR
[ ] Avro
[ ] Protobuf
[ ] Ion

I'm pausing here to take feedback (on both PRs) before proceeding with the last three formats (which I'm slightly less familiar with anyway).

cowtowncoder commented 2 years ago

As per my other note, let's split things so that we'll

First add new read capability, overrides for formats, basic tests to verify backend exposes values as exposed
Then add functionality that uses capability detection (as there are a few details to figure out, as per my notes on jackson-core issue)

cowtowncoder commented 2 years ago

ok, merged: I can take care of the other backends too; added Avro, test.

cowtowncoder commented 2 years ago

Clarification: I'll take care of adding capability setting, introspection, but if you have spare cycles for testing actual behavior that'd be great. If not, we'll get those eventually. :)