search

FasterXML / jackson-dataformats-binary

Uber-project for standard Jackson binary format backends: avro, cbor, ion, protobuf, smile
Apache License 2.0
310 stars 133 forks source link

check added to prevent IonValue null deserialization to fail when bean has a missing property #322

Closed atokuzAmzn closed 2 years ago

atokuzAmzn commented 2 years ago

This PR aims to resolve the issue https://github.com/FasterXML/jackson-dataformats-binary/issues/317 This is a duplicate of https://github.com/FasterXML/jackson-dataformats-binary/pull/320 which was created over 2.14. This PR is created using 2.13 branch as base.

Changes:

cowtowncoder commented 2 years ago

Happy to merge.

Just one last thing: @atokuzAmzn have I asked for and gotten a CLA for you? If not, it's a one-page doc from here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual method is to print it, fill & sign, scan/take photo, email to info at fasterxml dot com. This only needs to be done once and CLA is good for all future use for all contributions to Jackson projects. Apologies if I forgot that you have sent one (if so let me know).

With CLA I'll merge this ASAP and it will get in 2.13.3 release!

Thank you once again for going through the process & apologies for slowness on my part.

atokuzAmzn commented 2 years ago

@cowtowncoder I have emailed the CLA to the info email.

cowtowncoder commented 2 years ago

CLA clear now, will merge.