search

FasterXML / jackson-dataformats-binary

Uber-project for standard Jackson binary format backends: avro, cbor, ion, protobuf, smile
Apache License 2.0
310 stars 133 forks source link

Missing license file in Maven package for newer versions #354

Closed desombre closed 1 year ago

desombre commented 1 year ago

The license file is missing in newer versions of the Maven packages source code. see: https://repo1.maven.org/maven2/com/fasterxml/jackson/dataformat/jackson-dataformat-cbor/2.14.2/ -> jackson-dataformat-cbor-2.14.2-sources.jar In older versions e.g. 2.6.7 it was included.

cowtowncoder commented 1 year ago

Hmmh. Odd, I do not recall this being done on purpose. But looking quickly at repo, it looks like LICENSE would not only be missing from source jars but also binary ones. I wonder if this has been the case since 2.10 when multiple individual repositories were merged; addition of another level may have made parent-level LICENSE not found by sub-modules.

Anyway: need to make this work. Thank you for reporting the issue, @desombre !

cowtowncoder commented 1 year ago

Fixed this for all dataformat modules (here and otherwise), backporting into 2.12 onwards (in off-chance there might be micro-patches or something). But will be included in 2.14.3 and 2.15.0 when those get released.