Fix #399; support SmileBufferRecycler via new 2.16 pluggable mechanism

FasterXML / jackson-dataformats-binary

Uber-project for standard Jackson binary format backends: avro, cbor, ion, protobuf, smile

Apache License 2.0

310 stars 133 forks source link

Fix #399; support SmileBufferRecycler via new 2.16 pluggable mechanism #402

Closed cowtowncoder closed 11 months ago

cowtowncoder commented 12 months ago

As per title, if we want to continue buffer recycling, here are changes for minimal upgrade.

But based on local performance testing it is not certain recycling is worth it -- will next consider that.

pjfanning commented 11 months ago

@cowtowncoder is this going to dropped out of 2.16 release? The RC1 has been published and ideally we wouldn't want to sneak in extra changes unless necessary.

cowtowncoder commented 11 months ago

@pjfanning I decided to instead drop buffer recycling for Smile altogether, so this PR is not necessary -- but I kept it around as sample in case similar was needed for say Avro. But I can now close this as "won't do". Thanks for the reminder.