search

FasterXML / jackson-dataformats-binary

Uber-project for standard Jackson binary format backends: avro, cbor, ion, protobuf, smile
Apache License 2.0
310 stars 133 forks source link

Some clean up #409

Closed thetric closed 9 months ago

thetric commented 11 months ago

This PR is best reviewed commit by commit

cowtowncoder commented 11 months ago

Hmmh. Going forward, I think PRs like this might be good to split to multiple ones... even if changes are mechanical.

Also, no need to backport into 2.15, 2.16 would have been better target since there are no fixes. But 2.15 ok for now.

cowtowncoder commented 11 months ago

@thetric Looks good, will review and can merge. Thank you for contributing this!

But first, before merge, I'll need one thing from you: CLA (assuming you haven't sent one; I tried checking, apologies if I missed it). CLA is found here:

https://github.com/FasterXML/jackson/

(https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf specifically)

and is usually printed, filled & signed, emailed to fasterxml dot com.

Once I get it, I can proceed with merging.

Thank you once again for contributing this!

cowtowncoder commented 11 months ago

Ok, I will not merge this quite as-is; merged a subset into 2.16 and would be happy to merge rest mostly. Also fixed the non-annotated test case.

If it is easy to re-generate changes against 2.16 another PR would make sense.

cowtowncoder commented 9 months ago

As per my earlier note; some changes merged, but will not apply to 2.15, too much churn. Am open to getting PR for 2.17, ideally separated by change type.