search

FasterXML / jackson-dataformats-binary

Uber-project for standard Jackson binary format backends: avro, cbor, ion, protobuf, smile
Apache License 2.0
316 stars 136 forks source link

Handle value overflow checks for IonParser.getIntValue() - #428 #481

Closed thomasdelange5 closed 9 months ago

thomasdelange5 commented 9 months ago

Add number size checks for IonParser getIntValue and getLongValue. Fix failing tests for #428

cowtowncoder commented 9 months ago

Looks good @thomasdelange5 -- thank you for contributing this!

Only one other thing before I can merge this: if we haven't gotten CLA for you yet (it only needs to be done once per contributor):

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

(or possibly alternate Corporate CLA addendum if this is under some company's; we have a few Amazon contributors for Ion). It is usually easiest to fill & sign, print, scan/photo, email to cla at fasterxml dot com. Once we have it (and if you have sent previously, let me know please), I can proceed with merging this fix!

thomasdelange5 commented 9 months ago

Thank you for getting back so quickly @cowtowncoder! I will remove that catch clause and submit the CLA now.

cowtowncoder commented 9 months ago

CLA received, will merge for 2.17(.0).

Thank you, @thomasdelange5 !

thomasdelange5 commented 9 months ago

Awesome, thank you very much!

On Fri, Feb 9, 2024 at 5:40 PM Tatu Saloranta @.***> wrote:

Merged #481 https://github.com/FasterXML/jackson-dataformats-binary/pull/481 into 2.17.

— Reply to this email directly, view it on GitHub https://github.com/FasterXML/jackson-dataformats-binary/pull/481#event-11763047573, or unsubscribe https://github.com/notifications/unsubscribe-auth/BB3SKLXA4JYV3PQVSZNJK5DYS2QU3AVCNFSM6AAAAABDBVTUTKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRG43DGMBUG42TOMY . You are receiving this because you were mentioned.Message ID: <FasterXML/jackson-dataformats-binary/pull/481/issue_event/11763047573@ github.com>