search

FasterXML / jackson-dataformats-binary

Uber-project for standard Jackson binary format backends: avro, cbor, ion, protobuf, smile
Apache License 2.0
316 stars 136 forks source link

Issue #76: fix wire type checking for packed repeated fields #77

Closed knoguchi closed 7 years ago

knoguchi commented 7 years ago

Fixed the isValidFor method. The deserializing of the repeated field to an array seems to be fine.

cowtowncoder commented 7 years ago

Sounds reasonable, but would it be possible to have a test case? This would help against regression.

knoguchi commented 7 years ago

Added the test case. Currently Travis fails for the master branch. An Avro test case is failing but that's nothing to do with my change.

cowtowncoder commented 7 years ago

Ok I had accidentally added failing avro test under other tests, not under failing; moved so it won't block builds.

cowtowncoder commented 7 years ago

Ok I'm happy to merge this fix (and related) test. Just one thing before merging the contribution; if we haven't yet asked, we'd need a Contributor License Agreement (CLA):

 https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the easiest way is often to just print, fill & sign, scan, email to info at fasterxml dot com. If that could be done I'd be happy to merge this and then tackle encoding side.

Thank you in advance!

knoguchi commented 7 years ago

I've signed and sent the CLA as instructed. Thank you.

cowtowncoder commented 7 years ago

@knoguchi For some reason I don't seem to have that... will try to check my inbox at fasterxml (I get info forward to my account).