search

FasterXML / jackson-dataformats-binary

Uber-project for standard Jackson binary format backends: avro, cbor, ion, protobuf, smile
Apache License 2.0
311 stars 135 forks source link

[ion] Ion type annotations not written for scalar and list types on serialization #97

Open mcliedtke opened 7 years ago

mcliedtke commented 7 years ago

Creating an issue based on the Google Groups discussion.

Issue: Ion type annotations are not written when using IonAnnotationTypeSerializer. This is due to un-implemented writeTypePrefixForScalar and writeTypePrefixForArray methods in the class.

Will see if I can work on a PR, with tests, for the fix.

cowtowncoder commented 7 years ago

Quick note here: I decided to do a significant rewrite of type id write methods, and this gives more control to actual JsonGenerator subtype. I hope this helps in handling this better, for 2.9.0.

mcliedtke commented 7 years ago

The refactoring done resolved the original issue. Confirmed through tests added in this PR: https://github.com/FasterXML/jackson-dataformats-binary/pull/109