search

FasterXML / jackson-datatype-joda

Extension module to properly support full datatype set of Joda datetime library
Apache License 2.0
140 stars 81 forks source link

add no-arg constructor for DateTimeDeserializer #125

Closed abbychau closed 2 years ago

abbychau commented 2 years ago

issue #124

cowtowncoder commented 2 years ago

Quick question here... I am bit confused: constructor being added takes 1 argument; it's not a no-args constructor. I should have noticed and mentioned this earlier. This would not work with annotations yet, only truly 0-argument constructor would.

abbychau commented 2 years ago

sorry. You are right. I made a mistake. I just changed that to a 0-arg.

cowtowncoder commented 2 years ago

Ok; this might work, but I think one thing we really need here is a unit test, to verify specified usage works. Especially since is a new feature at this point, something that did not work before.

Would it be possible to add that? Apologies for not asking for this earlier.

abbychau commented 2 years ago

@cowtowncoder just added. Could you check whether the test case matches the standard?

cowtowncoder commented 2 years ago

Looks good. Thank you! Will merge for 2.14.