FasterXML / jackson-datatypes-collections

Jackson project that contains various collection-oriented datatype libraries: Eclipse Collections, Guava, HPPC, PCollections
Apache License 2.0
79 stars 53 forks source link

try to fix [ #106 ](https://github.com/FasterXML/jackson-datatypes-collections/issues/106) #107

Closed magical-l closed 1 year ago

magical-l commented 1 year ago

try to fix #106

cowtowncoder commented 1 year ago

Makes sense, would be happy to merge this.

Before merging I do need one more thing: CLA (if I haven't asked for one before -- it only needs to be sent once and is good for all future contributions). It's from here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual way is to fill it, sign, scan/photo, email to info at fasterxml dot com.

Once I have it I'll merge this PR.

Thank you again for contributing it; looking forward to merge!

magical-l commented 1 year ago

@cowtowncoder ok, I'll print the pdf, fill, sign, take a photo with mobile, and email to the address. is it ok?

cowtowncoder commented 1 year ago

@magical-l Usually you do not modify PDF, but print a copy, fill in paper version, scan (or take a photo).

But if you prefer, editing PDF works too; this has been done by some contributors. There are free tools for doing that. Either way works fine.

cowtowncoder commented 1 year ago

Yes, that works fine.

On Thu, Mar 2, 2023 at 7:39 PM magical-l @.***> wrote:

@cowtowncoder https://github.com/cowtowncoder ok, I'll print the pdf, fill, sign, take a photo with mobile, and email to the address. is it ok?

— Reply to this email directly, view it on GitHub https://github.com/FasterXML/jackson-datatypes-collections/pull/107#issuecomment-1452914943, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAANOGIYAKU3HQHPJWAHGYDW2FRVPANCNFSM6AAAAAAVLSEU3U . You are receiving this because you were mentioned.Message ID: @.***>

cowtowncoder commented 1 year ago

@cowtowncoder ok, I'll print the pdf, fill, sign, take a photo with mobile, and email to the address. is it ok?

Yes, that's perfect.

magical-l commented 1 year ago

@cowtowncoder oh no...I found the email was rejected... sent from my email lwj621 at 163 dot com

The response was: Your email to group info@fasterxml.com was rejected due to spam classification. The owner of the group can choose to enable message moderation instead of bouncing these emails. More information can be found here: https://support.google.com/a/answer/168383.

cowtowncoder commented 1 year ago

@magical-l That is unfortunate. I don't have anything set up on my side to block that domain.

Maybe you can sending this directly to my alias "tatu" at fasterxml dot com, and see if that works better. If not, I can share my secondary email.

cowtowncoder commented 1 year ago

CLA received! Can now just merge.