Closed saydar31 closed 11 months ago
Looks good so far! Added some small suggestions.
One thought on deserialization: for non-typed (no polymorphic type) case could probably allow both JSON Object and JSON String values, regardless of @JsonFormat
settings, if any.
Things do get more complicated for typed (polymorphic) case, where format possibly has to be taken into account as Type Id inclusion is offected -- Scalar values (String), for example, cannot use "As.PROPERTY" type-id inclusion but only WRAPPER_OBJECT/WRAPPER_ARRAY. Whereas JSON Object values allow any and all inclusion.
@saydar31 Any updates?
I would be willing to merge serialization-only implementation.
One thing that is needed, I think, is CLA (if not yet sent). It's here:
https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf
and the usual way is to print, fill & sign, scan/photo, email to info
at fasterxml dot com.
Once I receive it (this is only needed once, before the first contribution by new contributor), I can merge the PR (assuming everything's good).
Looking forward to getting this merged for 2.16!
I tried to find ways to ask @saydar31 if he's wililng to submit CLA, but no contact info anywhere 😅
Tatu,
Now that serialization for Guava Range objects is implemented, could we close this PR?
Appreciate @saydar31's contributions, though it's regrettable that the CLA was not submitted.
@mukham12 Yes, thank you for the reminder. Will close.
Motivation
Close issue #118
Still have some questions about implementation, but serialization already works