FasterXML / jackson-datatypes-collections

Jackson project that contains various collection-oriented datatype libraries: Eclipse Collections, Guava, HPPC, PCollections
Apache License 2.0
79 stars 53 forks source link

PCollections module info (`module-info.class`) incorrect #122

Closed bowbahdoe closed 1 year ago

bowbahdoe commented 1 year ago
        <dependency>
            <groupId>com.fasterxml.jackson.datatype</groupId>
            <artifactId>jackson-datatype-pcollections</artifactId>
            <version>2.15.3</version>
        </dependency>

        <dependency>
            <groupId>org.pcollections</groupId>
            <artifactId>pcollections</artifactId>
            <version>4.0.1</version>
        </dependency>
 Error occurred during initialization of boot layer
java.lang.module.FindException: Module pcollections not found, required by jackson.datatype.pcollections

Their module name is now org.pcollections https://github.com/hrldcpr/pcollections/blob/master/src/main/java/module-info.java

cowtowncoder commented 1 year ago

Thank you for reporting this @bowbahdoe. Sounds like something to fix in config file for Moditect.

bowbahdoe commented 1 year ago

@cowtowncoder You fixed that without bumping the minimum version of pcollections. This was an error encountered with 4.x.y, I don't know if it was an issue with 2.x.y

cowtowncoder commented 1 year ago

Ugh. Was too hasty, assumed it was a problem you had encountered and... crap. But the problem description was somewhat misleading. Even then, I should have paid attention to the version number.

Thank you for pointing this out; will change.

cowtowncoder commented 1 year ago

Updated for 2.16.0. For 2.15.x bit unclear on what to do since as far as I can see, module-info is only added in PCollections 4.0.1 -- so there is no module name for prior versions. But also not sure how safe it'd be to upgrade PCollections dependency from 2.x to 4.x in a patch (of 2.15).