FasterXML / jackson-datatypes-collections

Jackson project that contains various collection-oriented datatype libraries: Eclipse Collections, Guava, HPPC, PCollections
Apache License 2.0
79 stars 53 forks source link

Fix 2 flaky tests in class FluentIterableTest. #91

Closed LALAYANG closed 3 years ago

LALAYANG commented 3 years ago
  1. Test failures:
    • Run: mvn -pl guava edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=com.fasterxml.jackson.datatype.guava.FluentIterableTest, *Here are the details of NonDex.
    • Two tests fail: com.fasterxml.jackson.datatype.guava.FluentIterableTest.testSerialization com.fasterxml.jackson.datatype.guava.FluentIterableTest.testWrappedSerialization
cowtowncoder commented 3 years ago

First of all, thank you for contributing this! Fix would be great.

Just onet thing: I do not want to add a new dependency for just one test. It'd be great to do the test using just Jackson (or simple String processing.

cowtowncoder commented 3 years ago

Oh actually I see: it is iterating over the hash set contents.

cowtowncoder commented 3 years ago

@LALAYANG I figured that an even simpler way is to ensure iteration order is set, which happens when using a List.

Thank you once again for identifying the issue!