Remove unnecessary synchronization from endpoint reader/writer caches

FasterXML / jackson-jaxrs-providers

Multi-module project that contains Jackson-based "old" JAX-RS (ones under `javax.ws.rs`) providers for JSON, XML, YAML, Smile, CBOR formats

Apache License 2.0

111 stars 78 forks source link

Remove unnecessary synchronization from endpoint reader/writer caches #167

Closed pjfanning closed 1 year ago

pjfanning commented 1 year ago

relates to https://github.com/FasterXML/jackson-jaxrs-providers/issues/166
current synchronization does not prevent concurrent threads finding there are no cached instances and then multiple threads can create instances - once an instance is cached, then this will no longer happen
if we want proper control so that concurrent threads can't create multiple instances, we could look at LRUMap and introduce something like Map.computeIfAbsent

cowtowncoder commented 1 year ago

@pjfanning LGTM. Just one question -- I think this should be safe enough to include in 2.14.2? If you agree could you re-base against 2.14 branch. I'll be happy to merge either way.

pjfanning commented 1 year ago

let me rebase the branch to v2.14

pjfanning commented 1 year ago

@cowtowncoder rebased