search

FasterXML / jackson-jdk11-compat-test

Test project for verifying Jackson's support of JDK9+ Module system
3 stars 3 forks source link

2.10 Patch 1 - Progress for JMod, JLink, JPackage for more modules #3

Open GedMarc opened 4 years ago

GedMarc commented 4 years ago

Thread used to monitor the progress of the following modules for JLink and package building

GedMarc commented 4 years ago

Currently working on a failing multi-release jar for javax.xml.bind

[ERROR] Error: java.lang.IllegalArgumentException: META-INF.versions.9.javax.xml.bind: Invalid package name: 'META-INF' is not a Java identifier

All other modules compiling successfully

GedMarc commented 4 years ago

All snapshots uploaded - 5 Javadoc errors to resolve on a few of the shades then release.

Snapshot Repo : https://oss.sonatype.org/#nexus-search;quick~com.guicedee.services Jax-RS/Servlet : https://oss.sonatype.org/#nexus-search;quick~com.guicedee.servlets

All Build Location : https://jwebmp.com/teamcity

Starting on the jdk11 compatibility project and jlink builds

cowtowncoder commented 4 years ago

Let me know if and when Jackson component poms/module-infos need tweaks.

GedMarc commented 4 years ago

Finally!!

https://github.com/FasterXML/jackson-jdk11-compat-test/pull/4

Guava needs 

requires static guava;
requires static com.google.common

to enable 26.jre and up

Yaml i'm not sure how to proceed, shade in or otherwise Mr bean missing everything sigh

I'm going to start putting some of the jaxrs, hibernate and org.json tests in now hopefully guicedee.com website up tomorrow or soon-ish

cowtowncoder commented 4 years ago

@GedMarc so just to make sure: add these 2 but also remove requires guava?

GedMarc commented 4 years ago

Oh sorry, replace requires guava with

requires static guava;
requires static com.google.common

What version of hibernate does the jackson library need to support?

cowtowncoder commented 4 years ago

there are separate modules for Hibernate 3, 4 and 5. But 5 is a mess. I don't intend to continue that module past 2.x.

But for now I assume Hibernate 5(.2+) should be supported. H4 maybe if easy, H3 doesn't matter (by d/l counts).

cowtowncoder commented 4 years ago

Updated Guava module's module-info in 2.10 and above.

cowtowncoder commented 4 years ago

With YAML, 3.0 switches to new snakeyaml-engine, which should be better maintained and would probably accept patches to generate/use module-info. Not sure about status of "classic" SnakeYAML. We could possibly consider backporting change to snakeyaml-engine for 2.11 or later; there is nothing fundamentally preventing it I think.

cowtowncoder commented 3 years ago

Getting error

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-toolchains-plugin:1.1:toolchain (default) on project jackson-jdk11-compat-test: Cannot find matching toolchain definitions for the following toolchain types:
[ERROR] jdk [ vendor='oracle' version='1.11' ]
[ERROR] Please make sure you define the required toolchains in your ~/.m2/toolchains.xml file.

on my new mini-Mac, missing (as per error) definitions. Would be good to add a note on README linking to a page that explains what is needed. See if I can duckduckgo something.