fixed id comparison in _equals

FasterXML / jackson-module-jsonSchema

Module for generating JSON Schema (v3) definitions from POJOs

370 stars 136 forks source link

fixed id comparison in _equals #146

Closed cernautan closed 2 years ago

cernautan commented 2 years ago

I think the protected boolean _equals(JsonSchema that) contains an issue on the 'id' comparison line. It should be equals(getId(), that.getId()) instead of the current code that is equals(getId(), getId()).

cowtowncoder commented 2 years ago

Looks like a legit fix, will merge. Would be great to have a unit test to verify but implementation looks wrong so...